feat: determine connected components #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilasPeters
force-pushed
the
feat/0078-spawn-teleporters---connected-components
branch
from
b921321 to
14b0707
Compare
Tboefijn
requested changes
Apr 15, 2024
SilasPeters
force-pushed
the
feat/0078-spawn-teleporters---connected-components
branch
2 times, most recently
from
59ac5aa to
995efeb
Compare
3 tasks
joachimdekker
requested changes
Apr 21, 2024
joachimdekker
previously approved these changes
Apr 22, 2024
LukaBerkers
requested changes
Apr 22, 2024
Comment on lines
171
to
175
| if (cell.Tile.CanConnectInDirection(East) && neighbour.X > cell.X && neighbour.Tile.CanConnectInDirection(West)) | ||
| connectedNeighbours.Add(neighbour); | ||
| else if (cell.Tile.CanConnectInDirection(West) && neighbour.X < cell.X && neighbour.Tile.CanConnectInDirection(East)) | ||
| connectedNeighbours.Add(neighbour); | ||
| else if (cell.Tile.CanConnectInDirection(North) && neighbour.Y > cell.Y && neighbour.Tile.CanConnectInDirection(South)) | ||
| connectedNeighbours.Add(neighbour); | ||
| else if (cell.Tile.CanConnectInDirection(South) && neighbour.Y < cell.Y && neighbour.Tile.CanConnectInDirection(North)) | ||
| connectedNeighbours.Add(neighbour); |
There was a problem hiding this comment.
I don't really understand this if statement. They all result in the same code. It seems like this should be a big or statement, hopefully formatted somewhat nicely.
There was a problem hiding this comment.
You're damn right.
Tboefijn
requested changes
Apr 22, 2024
Tboefijn
previously approved these changes
Apr 22, 2024
SilasPeters
force-pushed
the
feat/0078-spawn-teleporters---connected-components
branch
from
8f14356 to
8c40cfe
Compare
LukaBerkers
approved these changes
Apr 22, 2024
This commit allows determining the connected components, and visualises them in the ConnectedComponents scene by coloring the tiles
This prevents primitive blindness. Now code can more easily be read
SilasPeters
force-pushed
the
feat/0078-spawn-teleporters---connected-components
branch
from
d59a145 to
c728115
Compare
SilasPeters
deleted the
feat/0078-spawn-teleporters---connected-components
branch
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit allows determining the connected components, and visualises them in the
ConnectedComponentsscene by coloring the tiles.In the process of doing so, I fixed some orientation bugs in the Tile classes, notably the
CornerandTSection.Testability
See for yourself, and good around! Look for the
ConnectedComponentsscene.Checklist